[Fixed 69730] Elven brandy batch farming reduction time and animation

1. Title: Elven brandy batch farming reduction time and animation.
2. Reproducible: 100%
3. Blocker: No
4. Details: The Elven brandy reduces the batch farming time by eight percent however the animation time is not reduced resulting in a tiny lag before proceeding with the next batch.
   
   
   
   
   
   
5. Steps to Reproduce: Drink an Elven brandy and start to water a plant, as soon as you do toggle auto run and position the camera for a clear path, watch the watering animation and notice it continues after the progress bar ends which is made obvious by the time it takes for the avatar to start moving. Note I only tested this for watering but assume it affects sowing and harvesting.
6. User Specs: (RAM, CPU, GPU and Operating System only)
   
   OS: Windows 10 (10.0.0) 64bit
   CPU: Intel(R) Core(TM) i5-6400 CPU @ 2.70GHz (4) System RAM: 16284
   GPU: NVIDIA GeForce GTX 1060 6GB GPU RAM: 6052
   SotA.Win.64.1289.Date.09.23.20
   Area: POT_grassland_metropolis_01a_template/Wisteria Lane
   Area Display Name: Wisteria Lane
   Loc: (141.3, 41.7, -43.6)
   Debug: UE9UX2dyYXNzbGFuZF9tZXRyb3BvbGlzXzAxYV90ZW1wbGF0ZXxXaXN0ZXJpYSBMYW5lfCgxNDEuMjg0LCA0MS42NzUsIC00My41NTMpfCgwLCAwLjY5NSwgMCwgMC43MTkpfDgwOC4wMDM4fDU3LjAwNTI4fDEwLjU3Njky​

Edit: Added example video.
Edit: Renamed one year whiskey to Elven brandy.

 

Just planted Pumpkin Plant Seeds (in a Dungeon, if that matters).

Batch Sowing Seeds - Animation matched the countdown timer (this has no skill heat timer). No issue.
Batch Watering - Animation mostly matches the countdown timer and skill heat timer. The animation does finish before the skill heat timer expires.

Will have to wait on harvesting.

Just defining the countdown timer as this thing:


09/25/2020 20:47
Title:
Reproduction Rate:
Blocker?
Details:
Steps to Reproduce:
User Specs:
OS: Windows 10 (10.0.0) 64bit
CPU: Intel(R) Xeon(R) CPU E5-1620 0 @ 3.60GHz (8) System RAM: 16303
GPU: NVIDIA GeForce GTX 1080 GPU RAM: 8079
SotA.Win.64.1289.Date.09.23.20
Area: PlayerDungeon_GreenBrickFoyer_3Connections
Area Display Name: Player Dungeon
Loc: (-0.4, 0.0, -31.7)
Debug: UGxheWVyRHVuZ2Vvbl9HcmVlbkJyaWNrRm95ZXJfM0Nvbm5lY3Rpb25zfHwoLTAuNDMzLCAwLjAwOCwgLTMxLjcyOSl8KDAsIC0wLjk2NiwgMCwgMC4yNTcpfDEzMzd8MjguOTEwMjl8OC41OTkyMTM=

 

Added watering and harvesting videos.

 

Renamed the one year whiskey to its new name of Elven brandy, bug still persists.

 

@Lained were you the only person in the scene at the time? Maybe there was some network delays? I just tested alone in a scene (scene master) in my greenhouse and everything seemed OK (sowing and watering).

 

@Echondas Pretty sure I was alone in the scene, yes.

 

OK thanks - I'll keep an eye on the timings when I water later and harvest tomorrow. Definitely seems like the timing is off in your videos, but I wanna try and reproduce it first hand before marking it verified.

 

@Echondas with the double experience still active I decided to up my agricultural skills from 124 to 134 for the slightly larger radius as I sometimes miss a patch here or there it also shortens the timing slightly, it looks like it's trying to play another loop of the animation but then cancels it as it's not required.

 

@Echondas DID verify this already, must have gotten lost in the db failure.

 

Yep, it must have gotten lost. I also moved it to the Animation folder, since the bug is that the animation length doesn't scale with the progress bar.
Moving it to the animation forum again now

 

Submitted: Issue 69730

 

Fixed, just needs to patch in.

"Animation lengths for sowing seeds, watering plants, and harvesting plants have been reduced so that players utilizing Elven Brandy no longer experience animations delaying their next agriculture skill attempt. Also lock times and cool downs have been reduced to provide a smoother transition from one agriculture skill attempt to another."

CL 214578

 

fix needs testing as of 1458

 

Confirmed.