[Fixed] Death touch and other "Fist" spellis are not getting crits like other spells

05/11/2021 07:34
Title: Death touch is not getting hardly any crits.
Reproduction Rate: 100%
Blocker? could be
Details: Death fist is not getting many crits. After playing for the last hour with OSX tool now installed I can see spell information. Death fist has crit only 3% fights, vs my other skills in death which are in the 40%. not sure if its by design or just something missing.
Steps to Reproduce: fight a mobs compare crit % between your other death skills vs death fist.
User Specs:
OS: Windows 10 (10.0.0) 64bit
CPU: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16) System RAM: 40762
GPU: NVIDIA GeForce RTX 2060 GPU RAM: 5980
SotA.Win.64.1382.Date.05.01.21
Area: Mistrendur_R4_ObsidianPanopticon
Area Display Name: The Obsidian Panopticon
Loc: (-71.0, 21.8, -203.7)
Debug: TWlzdHJlbmR1cl9SNF9PYnNpZGlhblBhbm9wdGljb258fCgtNzEuMDIzLCAyMS43NjIsIC0yMDMuNjUzKXwoMCwgMC44NjQsIDAsIDAuNTA0KXwxMTUuMTg4NXwxMi4yMjk1Mnw3Ljc3ODEyNg==

 

update: 3 destroyers later got 1 cirt from it.

 

@Xee You mean Death Touch?

 

yes, haha I keep calling it fist...

 

hah, I figured - just wanted to make sure I had the right skill to test.

 

I just tested this on a practice dummy -- with my skill at 56 and raised to 67 during the test - I got 12 criticals out of 100 casts, all of them were charged 4 stacks except 1 maybe 2.

Hey Xee maybe test on a dummy - perhaps the mobs you were using it on are resisting crits or something?

 

I will test further. I have 480int, full crit gear, potion 5% critical bonus. I was not seeing as often as you. should be on later this evening to try again.

 

I wasn't doing anything special when I tested.. wearing my usual self-crafted gear and quest items.. no buffs or devotionals, etc.. If you still are underwhelmed on the practice dummy, maybe try less gear and bonuses .. maybe that's the issue (something working in reverse)

 

I am only seeing 3% where all my other spells are 30-45%. not sure why its so much lower or if its meant to be low? but numbers are sure not where they should be based on my magic crit chance bonus.

 

@Xee I'll mark this for developer review.

 

It should be noted that none of the "fist" spells crit at a rate similar to other spells, they're all intrinsically low. Stone Fist, Flame Fist, and Ice Fist all have observed crit rates between 3-6% any time I've tested them, in builds where arrow spells, death field, fireball, etc, would reach 25-45% crit rates. (I had assumed that this was by design and that Death Touch was intended to be in line with them, though Death Touch doesn't function as a fist spell)

 

I am updating the title of this bug to reflect that - thanks!

 

Chris Tweeted this is being fixed - changed title from dev review to submitted to reflect this:

https://twitter.com/catnipgames/status/1397552783172194306

@catnipgames
Just fixed the crit chance on a bunch of spells. Apparently there was some really old logic that said if any damage was parryable it should use the calculation for "Physical" critical hits. This should fix the crit chance for touches and about a dozen other spells.

 

Fix Needs Testing as of 1386

 

Verified as working in 1390. Also verified with Xee.