Grant's Heraldry Generator

Discussion in 'The College of Arms' started by Grant MacGregor, Oct 30, 2013.

Thread Status:
Not open for further replies.
  1. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    Also just pushed v0.5.22, which further cleans up a few more bugs involving user accounts and login. Also added new fields. If you are missing these required fields, you will be redirected to update your account on your next login.
     
  2. Trenyc

    Trenyc Avatar

    Messages:
    1,505
    Likes Received:
    2,968
    Trophy Points:
    125
    Gender:
    Male
    Hey Grant, why are First Name and Last Name required fields?
     
    Time Lord likes this.
  3. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    They're not -- they are optional. When you log in, your missing fields should be highlighted in red. Are the first and last name fields highlighted for you?
     
    Time Lord and Lord Trenyc like this.
  4. Trenyc

    Trenyc Avatar

    Messages:
    1,505
    Likes Received:
    2,968
    Trophy Points:
    125
    Gender:
    Male
    First Name was highlighted, yeah.

    Is there a reason to collect that information at all? It seems to me we have no use for it, and even having the fields there might make some people feel like they have to fill it out, especially since you can't tell what's optional until you submit.
     
    Time Lord likes this.
  5. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    can you send me a screen shot with the highlighted first name? There should be no circumstance that it does that. I'm in IRC if you can meet there
     
    Time Lord and Lord Trenyc like this.
  6. Trenyc

    Trenyc Avatar

    Messages:
    1,505
    Likes Received:
    2,968
    Trophy Points:
    125
    Gender:
    Male
    Actually correction, it's not highlighting red. This is a JavaScript validation catch, not PHP. When I click Submit, a little white box appears under the topmost field that is blank explaining, "Please fill out this field." The message appears when I click "Update Account". This check seems to be occurring for all fields, too, so if I leave the password fields blank, I get the same thing for them.

    This is in Firefox 24ESR.

    Sorry, I can't get in IRC or upload a screenshot right now. Later I can.
     
    Time Lord likes this.
  7. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    Thanks for the clarification! I know what's happening now. Putting in a fix.
     
    Time Lord and Lord Trenyc like this.
  8. Trenyc

    Trenyc Avatar

    Messages:
    1,505
    Likes Received:
    2,968
    Trophy Points:
    125
    Gender:
    Male
    Do you think you could add indicators for required fields, too, so users can identify which fields are required before submitting?
     
    Time Lord likes this.
  9. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    Yes, have been contemplating that for some time now, just haven't had the chance.
     
    Time Lord, Lord Trenyc and Ronan like this.
  10. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    OK, v0.5.23 should fix the issues you found, Trenyc. Thanks for finding these bugs. :)
    Also removed first and last name fields. They weren't required, and had no use.
     
  11. Trenyc

    Trenyc Avatar

    Messages:
    1,505
    Likes Received:
    2,968
    Trophy Points:
    125
    Gender:
    Male
    Cool, thanks Grant. :)

    Are you currently planning to resend an email verification when a user changes his or her email address via the Profile's "Edit Details" page?
     
    Time Lord likes this.
  12. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    yes, planning to add email notifications on registration and editing, as well as indicating required fields.
     
  13. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    Also, some of you will be glad to hear this: I'm placing pattern rotation on the back burner for the moment, it's just taking too much time away from other things. Instead, I will focus on Counter-chaning next. This will require quite a bit of work, so I would guess I will need about 2 weeks to get it working, along with other things needing to get done as well. :) We'll pop the champagne when its done. :)
     
    Time Lord, Lord Trenyc, Ronan and 2 others like this.
  14. Rufus D`Asperdi

    Rufus D`Asperdi Avatar

    Messages:
    6,352
    Likes Received:
    15,804
    Trophy Points:
    165
    Gender:
    Male
    Location:
    Austin, TX
    Hey! How did O'Sullivan jump ahead of me in the feature priority list???

    ;)
     
  15. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    No worries, we'll get 2 birds with one stone on this one. :)
     
    Time Lord and Lord Trenyc like this.
  16. Trenyc

    Trenyc Avatar

    Messages:
    1,505
    Likes Received:
    2,968
    Trophy Points:
    125
    Gender:
    Male
    Don't count your chickens 'til they're hatched. :p
     
    Time Lord likes this.
  17. Knight Grant MacGregor

    Knight Grant MacGregor Avatar

    Messages:
    477
    Likes Received:
    568
    Trophy Points:
    55
    Gender:
    Male
    Location:
    California, USA
    There were some issues with the hosting provider this morning between 5:15AM and 7:45AM PST. These appear to be resolved now. Sorry for the inconvenience.
     
    Time Lord and Lord Trenyc like this.
  18. High Baron O`Sullivan

    High Baron O`Sullivan Avatar

    Messages:
    3,503
    Likes Received:
    8,140
    Trophy Points:
    165
    Gender:
    Male
    Location:
    is everything.

    Magic, and wine.
     
    Time Lord likes this.
Thread Status:
Not open for further replies.