Dismiss Notice
This Section is READ ONLY - All Posts Are Archived

[Under review] Player vendor orders needs more than 1000 limit with new crowns

Discussion in 'Release 63 QA Feedback' started by Elwyn, Feb 26, 2019.

Thread Status:
Not open for further replies.
  1. Elwyn

    Elwyn Avatar

    Messages:
    3,493
    Likes Received:
    4,662
    Trophy Points:
    153
    Gender:
    Male
    Location:
    San Antonio, TX
    The orders interface has a limit of 1000 items. With the new 1:100 crowns exchange, this is the equivalent of 10 old crowns, when in the past it was not unheard of to have orders as large as 100 crowns. So we need this to be changed to at least 10000.

    I'm not sure what the logic was behind the 1000 limit in the first place. The stacking limit is 32767, so there is a good reason for limiting it to 32767 or 30000.

    (I wonder what would happen if someone had a single item of 400 crowns for sale on their vendor. Hopefully nobody was that silly. At least an order like that could simply be removed instead of overflowing. And hopefully the case of a stack of 328 or more crowns in bank or inventory will be handled by splitting it? I'm going to make sure I don't have a stack that large just in case. Blimey, this redistribution of wealth is trickier than I thought!)
     
    Last edited: Feb 26, 2019
    that_shawn_guy likes this.
  2. that_shawn_guy

    that_shawn_guy Bug Hunter

    Messages:
    1,050
    Likes Received:
    2,753
    Trophy Points:
    125
    Location:
    earth... mostly
    this will heavily effect anyone putting up buy orders for cotos.

    sell/buy stack sizes should be the same and should be at least 100x current limits. otherwise, i'm not able to buy/sell coto stacks to match pre-r63 values.
     
  3. Elwyn

    Elwyn Avatar

    Messages:
    3,493
    Likes Received:
    4,662
    Trophy Points:
    153
    Gender:
    Male
    Location:
    San Antonio, TX
    I never saw anyone putting up more than 100 for order/sale, so I don't think 100x is necessary, and there's also the stack limit to consider which makes no more than ~30x possible. But 10x is definitely necessary, and has no technical reason against it. In fact, I didn't even know about the 1000 limit for orders until I saw someone mention it in the forums. Also consider what 100 old-cotos/10000 new-cotos is worth.
     
    that_shawn_guy likes this.
  4. Elwyn

    Elwyn Avatar

    Messages:
    3,493
    Likes Received:
    4,662
    Trophy Points:
    153
    Gender:
    Male
    Location:
    San Antonio, TX
  5. that_shawn_guy

    that_shawn_guy Bug Hunter

    Messages:
    1,050
    Likes Received:
    2,753
    Trophy Points:
    125
    Location:
    earth... mostly
    though rare, i have seen coto buy orders up for 1000.

    if i'm currently putting up an order for 100 cotos, i will need to have orders up at the same price per-stack for 10,000.
     
  6. Lord Subtleton

    Lord Subtleton Developer Emeritus

    Messages:
    993
    Likes Received:
    1,310
    Trophy Points:
    93
    Added issue #64018 for review
     
    Elwyn, Jaesun and Elrond like this.
  7. wizardsmoke

    wizardsmoke Programmer Moderator SOTA Developer

    Messages:
    699
    Likes Received:
    817
    Trophy Points:
    93
    Thanks for the feedback! We are changing the limit to 10000. We may review this again in the future if needed.
     
    Elwyn, Jaesun and that_shawn_guy like this.
Thread Status:
Not open for further replies.